Add ssl support to Windows builds, Appveyor #1439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jesus
reviewed
Jul 18, 2019
| IO.select(nil, [@socket.to_io]) | ||
| retry | ||
| end | ||
| end |
There was a problem hiding this comment.
This method name is #read_nonblock, shouldn't we raise Errno::EAGAIN rather than blocking?
It should be the callers responsibility to retry.
There was a problem hiding this comment.
Maybe have a look at 7165775?
There was a problem hiding this comment.
I don't recall. Since the error is handled in read_and_drop, if the change works,...
This was referenced Mar 12, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Also, dummy def for RDoc & YARD in mini_ssl.c