Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine PR's #1437, 44, & 63 #1464

merged 1 commit into from Nov 20, 2017


Copy link

No description provided.

Copy link

Ah, wonderful! Thank you!

@nateberkopec nateberkopec merged commit 7165775 into puma:master Nov 20, 2017
@MSP-Greg MSP-Greg deleted the stopgap_minissl branch November 20, 2017 13:36
Copy link
Member Author

I'm certainly glad it passed the 2nd time, as the failures were intermittent.

Re Appveyor and ruby-head (trunk), it is currently not 'allow-failure'. It will always return a build, but it may not be the most current, as it is tested. Said another way, if a build from yesterday passed, and subsequent builds fail, yesterday's build is what is used. From memory, I don't recall builds being broken for more than 24 hours.

But, from what I can tell, Travis does ruby-head builds once a day, and they are not tested. So, the possibility exists for a Travis build to be broken. Also, they currently aren't installing bundled gems.

Hence, for those reasons, Appveyor ruby-head can often be included in the normal build test result, but Travis may best be left 'allow-failure'. If it becomes an issue, feel free to change Appveyor (or ping me). Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants