Dev/ssl cipher support #1478
Merged
Dev/ssl cipher support #1478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t3spe
reviewed
Dec 4, 2017
test/test_binder.rb
Outdated
| def test_binder_parses_jruby_ssl_options | ||
| skip unless Puma.jruby? | ||
|
|
||
| keystore = File.expand_path "../../examples/puma/keystore.jks" |
|
Any update here? Many of the failures do not appear to be related to my changes and I'd like to resolve this. If there's a way to run the travis and/or appveyor tests locally, I would welcome any information on it. At this point, all tests pass locally. |
|
Thanks for the PR. I'm taking some time off during the holidays and probably won't be able to merge until 2018. |
|
any update on this? |
|
Would love to see this in soon too! |
Closed
|
The Travis errors appear to be from the compiler being updated, we'll need to fix those but this PR didn't cause that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows optional specifying of which ssl ciphers the server should support. Default behavior is unchanged.
Created from #1476 which was inadvertently closed.