Skip SSL tests instead silently passing them. #1500
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If SSL is not used, the tests might be silently passing, while they are
not executed at all.
Let me explain.
The think is that you might not be testing some functionality of Puma and you might not even notice it, because the behavior of test suite apparently depends on load order.
E.g. the test suite is failing for me when I try to execute the test suite like this:
But if you use the right load order, the test suite pass, although it ignores some tests:
But with the patch applied, you can see that some tests were actually skipped: