Don't call .stop on a server that doesn't exist #1655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mipearson I know it's been a while but are you able to share what the misconfiguration was? I'm trying to understand what's the root cause for this error on our production server. Thanks. |
|
@cpinto I don't, sorry. I remember it was something specific to our code. I'd recommend sourcing this branch into your |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore the branch name - this turns out to work! Fixes #1523 for us on 3.12.0.
Issue we had was a misconfiguration was causing puma to be SIGTERM'd by ECS before it could set
@serverto anything, which meant that as it tried to graceful stop it hit #1523, confusing our debugging efforts.