Report tcp 0 port properly. Fixes #1679 #1786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
test/test_binder.rb
Outdated
| @@ -54,7 +56,8 @@ def setup | |||
| def test_localhost_addresses_dont_alter_listeners_for_ssl_addresses | |||
| @binder.parse(["ssl://localhost:10002?key=#{@key}&cert=#{@cert}"], @events) | |||
|
|
|||
| assert_equal [], @binder.listeners | |||
| assert_equal "ssl://localhost:10002?key=#{@key}&cert=#{@cert}", | |||
There was a problem hiding this comment.
I don't understand why this PR adds a listener, and why that's "ok".
nateberkopec
force-pushed
the
b-correct-port
branch
3 times, most recently
from
3827f00
to
5143341
Compare
|
Oh interesting. When I don't add these to the listeners array, |
|
#1120 feels relevant. |
nateberkopec
force-pushed
the
b-correct-port
branch
2 times, most recently
from
75712a5
to
ec44a81
Compare
Bonus feature: we now log all localhost addresses that we're bound to, including ipv6 ones.
nateberkopec
force-pushed
the
b-correct-port
branch
from
ec44a81
to
5b3ca4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
No description provided.