Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small JRuby cleanups and optimizations #2012

merged 5 commits into from Oct 7, 2019


Copy link

@headius headius commented Oct 5, 2019

This PR contains a quick pass over the Http11 class and the generated parser to reduce allocation and other antipatterns.

  • Fast path hash access that does not need ThreadContext.
  • Reduced transcoding of Java strings into Ruby strings by caching ByteList versions statically.
  • Reduced allocation of call back objects by making them static.
  • Reduced loads of runtime and parser fields by passing them into callbacks.

The callbacks could also be made into Java lambdas, removing the anonymous classes from the jar file, but that would tie this code to Java 8 or higher. I believe there may still be some JRuby folks with legacy apps on JRuby 1.7 + Java 7. Lambdas versus anon classes would not make any performance difference here.

* Use fastARef/fastASet for hash access to avoid context load.
* Cache most Java strings used to create headers as ByteLists, to
  avoid re-encoding and re-constructing the byte[] and ByteList.
* Load parse buffer once in field handler.
* Eliminate deprecated construction of RaiseException and
  centralize logic.
Seven fewer objects and no eager lookup of the exception class.
Copy link
Contributor Author

headius commented Oct 5, 2019

See my comment here for reference: #2010 (comment)

Copy link
Contributor Author

headius commented Oct 5, 2019

Note: This PR does not include the changes from #2010. That patch may not apply cleanly over this one but it's a trivial change.

There's only ever one implementation of these, so just call them
@nateberkopec nateberkopec merged commit 31be928 into puma:master Oct 7, 2019
@headius headius deleted the jruby_optz branch October 8, 2019 18:13
This was referenced Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants