http11: Remove qsort code paths [changelog skip] #2073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[changelog skip]
The check only looks in the pull request title |
AnthonyClark
changed the title
[changelog skip] Had the following warning during compilation without the include: warning: implicitly declaring library function 'isspace' with type 'int (int)'
AnthonyClark
force-pushed
the
http11/qsort-simplify
branch
from
897e064
to
54e32ca
Compare
|
#1889 is very long term, more of an expression of my wish to narrow the scope of the native extensions. This is a great PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I was just trying to familiarize myself a bit with puma and was trying to track down the usage of the code behind the
if defined(HAVE_QSORT_BSEARCH). Looks like it was added back to mongrel in engineyard/mongrel@cd44d2e and then added to puma in 7c9d988 but I don't see it being used.Looks like it was removed form the Unicorn web server in https://bogomips.org/unicorn.git/commit/?id=9625ad39b73d3d1443ff097e9113d1ec9c9d5f00
Of course this isn't a super helpful change if there's plans to move from the c extension entirely (#1889)..
It doesn't look like there was any test coverage so I didn't add/remove there, but not skipping CI since it is a code change.
Your checklist for this pull request
I have added an entry to History.md if this PR fixes a bug or adds a feature. If it doesn't need an entry to HISTORY.md, I have added[changelog skip]to all commit messages.[ci skip]to the title of the PR.#issue" to the PR description or my commit messages.