Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
Refactor listener closing code #2112
This PR fixes a bug/issue where a Unix socket created for a control server (e.g.,
This fix has two parts:
I've modified the pumactl integration tests to ensure the unix paths are cleaned up after getting shutdown by
Finally, for related cleanup the call to
Your checklist for this pull request
Actually, Actions can't download the Ruby binary, although all of the Ruby binaries are downloaded on install..
Both the Ubuntu & macOS files come from the same place, https://github.com/ruby/ruby-dev-builder/releases. Why it can retrieve the macOS fine, but not Ubuntu is odd. The code used is standard GitHub code, it may not have any retry code, I'm not sure...
JFYI, I added two 'unless <io>.closed?' statements, and Actions Ruby 2.2 was failing on: