-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI [changelog skip] #2561
Fix CI [changelog skip] #2561
Conversation
@@ -15,6 +15,8 @@ gem "minitest-stub-const" | |||
gem "sd_notify" | |||
|
|||
gem "jruby-openssl", :platform => "jruby" | |||
# needed for rubocop | |||
gem "racc", :platform => "jruby" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a bug in rubocop that we need to add it? (Or bundler or JRuby)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably JRuby, but it's recent, and will probably be fixed in the future? Log from Actions:
Run bundle exec rake rubocop
rake aborted!
LoadError: no such file to load -- racc/info
/home/runner/.rubies/jruby-9.2.15.0/bin/bundle:23:in `<main>'
Now the JRuby release should include racc on its own again, can this work without the intervention? |
Thanks. I just checked in my fork. We bypass RuboCop on JRuby head, probably due to time. I just downloaded the latest Windows release, and the file is included. But, jruby-9.2.15.0 doesn't have racc installed or the file is still missing. See: https://github.com/MSP-Greg/puma/actions/runs/621117884 Does that seem correct? |
https://www.jruby.org/2021/03/03/jruby-9-2-16-0.html I was thinking of this release, which seeeeems to mention racc in its notes? yes, as a fix to the problem w/ 9.2.15.0 which would lack the racc. |
Everyone can keep an eye on it, but 9.2.16.0 isn't available yet from |
Sorry, I should have 'followed' the bug. I was working on other things and also irritated because 'Ruby packagers' should never remove default gems. There's enough issues with bundled gems (and default gems being converted to bundled gems)... |
Description
Fix CI
Please describe your pull request. Thank you for contributing! You're the best.
Your checklist for this pull request
[changelog skip]
or[ci skip]
to the pull request title.[ci skip]
to the title of the PR.#issue
" to the PR description or my commit messages.