improve remote_addr behavior #2653
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad of LOCALHOST; when the client disconects unexpectedly, default to the unspecified source IP instead of localhost
nateberkopec
reviewed
Jul 5, 2021
|
Had a think about it and I think both of these changes are an improvement. However, they both have the potential to break people's setups, so I think we need to park these until 6.0. Your other option is to put one or both changes behind a temporary config option that we will remove in 6.0. I don't have a lot of insight right now on whether or not the next release will be a minor or major, so no promises on how long this could stay parked. Had one small concern about ipv6, see comment. |
…spec/localhost addresses
nateberkopec
added
waiting-for-review
|
Removed waiting for review. This is only blocked on next major release. |
|
I'm thinking next release might be a major. |
|
Merged! |
|
Why not squash merging @nateberkopec ? |
|
Did it on the CLI and forgot 😆 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2652
Description
See #2652 for details; this makes two changes:
set_remote_address header: "header_name"functionality, if the header is not passed,REMOTE_ADDRis now set to the physical peeraddr instead of always being set to 127.0.0.1REMOTE_ADDRis now set to the unspecified source address ('0.0.0.0') instead of to '127.0.0.1'Your checklist for this pull request
[ci skip]to the title of the PR.#issue" to the PR description or my commit messages.