Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI - itermittent fix and RuboCop #2741

Merged
merged 2 commits into from
Nov 2, 2021
Merged

CI - itermittent fix and RuboCop #2741

merged 2 commits into from
Nov 2, 2021

Conversation

MSP-Greg
Copy link
Member

@MSP-Greg MSP-Greg commented Nov 2, 2021

Description

  1. test_thread_pool.rb - newer RuboCop fixes - fix RuboCop issue (newer RuboCop)

  2. test_cli.rb - fix (?) CI itermittent error. See https://github.com/puma/puma/runs/4073168355?check_suite_focus=true#step:9:602

TestCLI#test_control_clustered:
Errno::EAGAIN: Resource temporarily unavailable
    /Users/runner/work/puma/puma/test/test_cli.rb:28:in `sysread'
    /Users/runner/work/puma/puma/test/test_cli.rb:28:in `wait_booted'

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

@MSP-Greg MSP-Greg changed the title CI - intermittent fix and RuboCop CI - itermittent fix and RuboCop Nov 2, 2021
@dentarg dentarg merged commit cd940b7 into puma:master Nov 2, 2021
@MSP-Greg MSP-Greg deleted the ci-rubocop branch November 3, 2021 14:10
JuanitoFatas pushed a commit to JuanitoFatas/puma that referenced this pull request Sep 9, 2022
* test_thread_pool.rb - newer RuboCop fixes

* test_cli.rb - fix intermittent darwin error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants