Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Fix Timeout Errors when reading responses #2746

Merged
merged 1 commit into from Nov 3, 2021

Conversation

MSP-Greg
Copy link
Member

@MSP-Greg MSP-Greg commented Nov 2, 2021

Description

  1. Currently, integration tests stop the CI if a response read timeout happens. Catch the error and flunk the test.

  2. There are two methods in test_integration_cluster.rb that are used when generating several requests. One had a read timeout set to 20 seconds, the other (which has failed recently) had the timeout set to the default of 10. Increase to 15.

These timeout errors seem to have recently increased, may be due to a change in Actions runners...

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

@MSP-Greg MSP-Greg changed the title Fix Timeout Errors when reading responses [CI] Fix Timeout Errors when reading responses Nov 3, 2021
@MSP-Greg MSP-Greg merged commit 8ffe049 into puma:master Nov 3, 2021
@MSP-Greg MSP-Greg deleted the fix-ci-timeout branch November 3, 2021 14:09
@dentarg
Copy link
Member

dentarg commented Nov 3, 2021

Updating the PR title doesn't seem to change the proposed commit message for the squash commit in the GitHub UI, might be good to know.

@MSP-Greg
Copy link
Member Author

MSP-Greg commented Nov 3, 2021

Noticed that with another recent PR. Maybe the PR title is only used if there's more than one commit?

@dentarg
Copy link
Member

dentarg commented Nov 3, 2021

I've changed title with multiple commits but the proposed commit message hasn't changed then, so my guess it isn't propagating everywhere it could. Maybe some developer at GitHub will see our discussion and fix it. :) 🤞

JuanitoFatas pushed a commit to JuanitoFatas/puma that referenced this pull request Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants