Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in CONTRIBUTING [ci skip] #2805

merged 1 commit into from Jan 25, 2022


Copy link

@olleolleolle olleolleolle commented Jan 25, 2022


This PR fixes a typo.

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

@olleolleolle olleolleolle changed the title Fix typo in CONTRIBUTING Fix typo in CONTRIBUTING [ci skip] Jan 25, 2022
Copy link
Contributor Author

Well, dh_ function in Ubuntu 18.04 failed on CLI option not recognized. Let's say that's unrelated to this fix.

@dentarg dentarg merged commit 930e5b4 into puma:master Jan 25, 2022
Copy link

dentarg commented Jan 25, 2022

Well, dh_ function in Ubuntu 18.04 failed on CLI option not recognized.

Can you open an issue about that? So someone could take a closer look on it

@olleolleolle olleolleolle deleted the patch-3 branch January 25, 2022 10:58
Copy link
Contributor Author

@dentarg #2806

JuanitoFatas pushed a commit to JuanitoFatas/puma that referenced this pull request Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants