Don't crash when given a non-standard HTTP code #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanphx
added a commit
that referenced
this pull request
Jul 6, 2013
Don't crash when given a non-standard HTTP code
MSP-Greg
added a commit
to MSP-Greg/puma
that referenced
this pull request
Aug 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using 449 in an app, because it's actually appropriate for the situation. The Rack codes don't include that because it's non-standard (MSFT extension).
This was crashing puma and returning a 500 because turning
nilinto aStringis super hard for ruby. The error message was bizarre so took a while to track down. We ended up adding the 449 k/v pair to theRack::Utilshash, and that solves the problem.Going forward, there is this solution, or the call to
fetchshould just raise a more appropriate error and suggest a way to fix the problem (use a different code, or register a new code, which would need supporting code).