Fix using control server with IPv6 host #3181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSP-Greg
force-pushed
the
00-control-cli-ipv6
branch
from
a9b825e
to
495f347
Compare
MSP-Greg
force-pushed
the
00-control-cli-ipv6
branch
from
495f347
to
3468c4e
Compare
|
Small update:
|
nateberkopec
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Creating a server listener with an IPv6 host is working, but using an IPv6 host for the control server is not.
Fix, and add tests for both tcp & ssl connections. This involves trimming the surrounding brackets from the URI format (eg
[::1]) to the IP address format (eg::1).See 0976412
Tests fail on current master.
Your checklist for this pull request
[ci skip]to the title of the PR.#issue" to the PR description or my commit messages.