Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extconf.rb - fixup to detect openssl info in Ruby build #3271

Merged
merged 1 commit into from Oct 30, 2023

Conversation

MSP-Greg
Copy link
Member

Description

A common problem with gems that link to OpenSSL is determining which OpenSSL to use if the system has more than one version installed. One can use --with-openssl-dir, but we'd like to not require its use if possible.

MRI Ruby may contain info in its RbConfig::CONFIG['configure_args'] string that we can use to determine where OpenSSL is. Also, TruffleRuby often embeds the OpenSSL source.

What often happens is that the code in extconf.rb finds the openssl.pc file, but it is for the wrong OpenSSL version.

Update extconf.rb to take the above into account.

Note that --with-openssl-dir is still available, which overrides everything.

Closes #3266. Also see #2790, etc

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

@MSP-Greg MSP-Greg merged commit cdb2341 into puma:master Oct 30, 2023
60 of 64 checks passed
@MSP-Greg MSP-Greg deleted the 00-extconf-openssl.pc branch October 30, 2023 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Puma bundle error with v6.4
2 participants