-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Response headers set to lowercase #3305
base: master
Are you sure you want to change the base?
Response headers set to lowercase #3305
Conversation
fcefcee
to
517b2e0
Compare
@nikhilbhatt There is still one failed test here could you please fix it. |
517b2e0
to
402fe68
Compare
402fe68
to
ee713ec
Compare
fixed |
@nikhilbhatt what about this one and 408 error response Line 128 in 5145708
|
lib/puma/const.rb
Outdated
CONNECTION_CLOSE = "Connection: close\r\n" | ||
CONNECTION_KEEP_ALIVE = "Connection: Keep-Alive\r\n" | ||
CONNECTION_CLOSE = "connection: close\r\n" | ||
CONNECTION_KEEP_ALIVE = "connection: Keep-Alive\r\n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CONNECTION_KEEP_ALIVE = "connection: Keep-Alive\r\n" | |
CONNECTION_KEEP_ALIVE = "connection: keep-alive\r\n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Closes #3250
Response headers returned by puma will always be lowercase.
Your checklist for this pull request
[ci skip]
to the title of the PR.#issue
" to the PR description or my commit messages.