CI: Use Tempfile.create in TestIntegration

[dentarg]

Hopefully more stable:

• Don't let the config file go out of scope while it's still in use. #3408 (comment)

Similar change as #3296

[ioquatix]

The reason why I assigned it to an instance variable was to prevent GC. So I'm not sure why this change is required, however, I'm also not sure my change fixed the issue, since we saw some other IO related issue... I need to spend more time investigating this too.

[MSP-Greg]

Maybe:

if @config_file&.exist?
  @config_file.unlink
  @config_file = nil
end

[MSP-Greg]

The reason why I assigned it to an instance variable was to prevent GC.

Agree, that is an issue. A lot of these issues may be related to running test parallel, along with 'resource starved' CI runners. In the test update (which I haven't looked at for a while), I think I removed all the Tempfile.new use, along with a lot of fixes for blocking IO, etc, It was a lot more stable. There were a few lib file changes, so I started on extracing them, but haven't finished...

Re Tempfile.create, since we know that unlink will always run, why create finalizers?

[ioquatix]

Re Tempfile.create, since we know that unlink will always run, why create finalizers?

The only reason would be if you think there is a code path where that unlink is not called. e.g. non-trivial flow controls like exceptions, etc might skip your explicit unlink.

[dentarg]

All tests here are green so let's merge this and see how it plays out going forward?

[MSP-Greg]

@ioquatix I suspect if something stopped teardown, it's pretty severe, like a SEGV...