add pretty process name #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
| @@ -271,6 +271,8 @@ def run(background=true) | |||
| else | |||
| handle_servers | |||
| end | |||
|
|
|||
| $0 = name | |||
There was a problem hiding this comment.
It's probably not best to set $0 here. It should be done inside cli.rb instead, since Server can be embedded in another program and we shouldn't mess with their $0.
There was a problem hiding this comment.
What if we use Process.setproctitle if the target is running Ruby 2.1.0 or above?
|
It's been 24 days, no update. Are you able to continue working on this PR? |
|
i moved the code inside CLI, please take a look |
| else | ||
| Process.setproctitle process_title | ||
| end | ||
| end |
There was a problem hiding this comment.
We could make this a bit simpler
Process.respond_to?(:setproctitle) ? Process.setproctitle(process_title) : $0 = process_titleThere was a problem hiding this comment.
sure! updated commit
|
Thanks for making changes i'm 👍 on this functionality |
|
❤️ 😍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I'm new to Puma, looks great so far :)
I noticed the lack of a pretty process name, this is my attempt to add a simple (static) one, very similar to what Thin server does.
This also accepts an optional --tag parameter for additional text (useful to recognize different apps)
fixes #415