Assure worker index is always within 0...@options[:workers] #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanphx
added a commit
that referenced
this pull request
Jan 27, 2014
Assure worker index is always within 0...@options[:workers]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the minor issue I brought up in #440.
next_worker_indexwill now always be a number between 0 and the number of workers configured.I also added an integration test (t3.rb) that boots multiple workers and utilizes on_worker_boot. Perhaps it's testing too many things at once (multiple workers, on_worker_boot hook, index) — but it felt nice to have that code path tested.
Feel free to pull or just use as inspiration :)