pumactl - do not modify original ARGV #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It works in my case. Travis build failures are due to timeout - @vlmonk could you rebase and push it again? Probably the last patch for gemfile may be related to failure in travis.. |
ARGV used later in `lib/puma/cli.rb` to construct `restart_cmd`
|
@chulkilee I rebased branch, but travis still can't build it |
evanphx
added a commit
that referenced
this pull request
Jun 16, 2014
pumactl - do not modify original ARGV
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARGV used later in
lib/puma/cli.rbto constructrestart_cmdclose #436