Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo BUNDLER_GEMFILE -> BUNDLE_GEMFILE #540

Merged
merged 1 commit into from
May 27, 2014
Merged

Conversation

allaire
Copy link
Contributor

@allaire allaire commented May 27, 2014

I was wondering why puma was logging that I wasn't using puma via bundle exec when it was the case. Turns out ENV['BUNDLER_GEMFILE'] does not exists, ENV['BUNDLE_GEMFILE'] does:

ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../../Gemfile', __FILE__)

evanphx added a commit that referenced this pull request May 27, 2014
Typo BUNDLER_GEMFILE -> BUNDLE_GEMFILE
@evanphx evanphx merged commit b585ffb into puma:master May 27, 2014
@allaire
Copy link
Contributor Author

allaire commented May 27, 2014

Also @evanphx, should we activate prune_bundler by default when we detect the presence of a Gemfile and when the user has cluster mode, but without preload_app (since prune_bundler isn't compatible)? Is there any case where prune_bundler is not wanted when the user use both Bundler and Cluster mode without preload_app?

@allaire allaire deleted the patch-1 branch May 27, 2014 16:17
@evanphx
Copy link
Member

evanphx commented May 27, 2014

That's a good question. I'm not yet sure because it does alter the behavior a little and I didn't want to surprise anyone with it. Perhaps for 3.0 we do it by default.

@allaire
Copy link
Contributor Author

allaire commented May 27, 2014

Yeah I vote for this too.

Last question about that: Is it sure that an error will happen if prune_bundler isn't set and we use phased restart with keep_releases 5 in Capistrano? I can't recall if this happened on our last project, but we often restarted the app without phased-restart!

@seuros
Copy link

seuros commented May 27, 2014

Only if your gemfile changed.

@allaire
Copy link
Contributor Author

allaire commented May 27, 2014

@seuros makes sense, thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants