Update lowlevel error message to be more meaningful. #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would probably also be really helpful to use the text 'Puma' in the message, like it does on "An unhandled low level error occurred. The puma application logs may have details.\n" |
evanphx
added a commit
that referenced
this pull request
Jan 20, 2015
Update lowlevel error message to be more meaningful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first time I saw this message, I thought "Why the fuck is the computer telling me about washing machines?". It took a bit of Googling and source reading to find out what exactly this meant. Here's a better message, slightly more informative, and one that will hopefully reduce confusion for others.