Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require Rack::Builder #699

Merged
merged 1 commit into from
May 19, 2015
Merged

Require Rack::Builder #699

merged 1 commit into from
May 19, 2015

Conversation

deees
Copy link
Contributor

@deees deees commented May 5, 2015

Fixes:

/opt/test/releases/20150505084239/vendor/bundle/ruby/2.2.0/gems/puma-2.11.2/lib/puma/configuration.rb:102:in `load_rackup': cannot load such file -- rack/builder (LoadError)
        from /opt/test/releases/20150505084239/vendor/bundle/ruby/2.2.0/gems/puma-2.11.2/lib/puma/configuration.rb:69:in `app'
        from /opt/test/releases/20150505084239/vendor/bundle/ruby/2.2.0/gems/puma-2.11.2/lib/puma/runner.rb:123:in `app'
        from /opt/test/releases/20150505084239/vendor/bundle/ruby/2.2.0/gems/puma-2.11.2/lib/puma/runner.rb:130:in `start_server'
        from /opt/test/releases/20150505084239/vendor/bundle/ruby/2.2.0/gems/puma-2.11.2/lib/puma/cluster.rb:213:in `worker'
        from /opt/test/releases/20150505084239/vendor/bundle/ruby/2.2.0/gems/puma-2.11.2/lib/puma/cluster.rb:109:in `block (2 levels) in spawn_workers'
        from /opt/test/releases/20150505084239/vendor/bundle/ruby/2.2.0/gems/puma-2.11.2/lib/puma/cluster.rb:109:in `fork'
        from /opt/test/releases/20150505084239/vendor/bundle/ruby/2.2.0/gems/puma-2.11.2/lib/puma/cluster.rb:109:in `block in spawn_workers'
        from /opt/test/releases/20150505084239/vendor/bundle/ruby/2.2.0/gems/puma-2.11.2/lib/puma/cluster.rb:105:in `times'
        from /opt/test/releases/20150505084239/vendor/bundle/ruby/2.2.0/gems/puma-2.11.2/lib/puma/cluster.rb:105:in `spawn_workers'
        from /opt/test/releases/20150505084239/vendor/bundle/ruby/2.2.0/gems/puma-2.11.2/lib/puma/cluster.rb:157:in `check_workers'
        from /opt/test/releases/20150505084239/vendor/bundle/ruby/2.2.0/gems/puma-2.11.2/lib/puma/cluster.rb:421:in `run'
        from /opt/test/releases/20150505084239/vendor/bundle/ruby/2.2.0/gems/puma-2.11.2/lib/puma/cli.rb:216:in `run'
        from /opt/test/releases/20150505084239/vendor/bundle/ruby/2.2.0/gems/puma-2.11.2/bin/puma-wild:31:in `<main>'

It happens when using phased restart and /opt/test/releases/20150505084239 old release directory (where puma started) is already gone (cleaned up by capistrano).

This is because rack uses autoload to lazyload all rack-related files (including rack/builder). But in this case it's not enough, require is more appropriate.

P.S. using prune_bundler option

@evanphx

evanphx added a commit that referenced this pull request May 19, 2015
@evanphx
Merge pull request #699 from deees/fix/require_rack_builder
6479e6b 
Require Rack::Builder
@evanphx evanphx merged commit 6479e6b into puma:master May 19, 2015
@deees deees deleted the fix/require_rack_builder branch May 19, 2015 06:34
@deees
Copy link
Contributor Author

deees commented Jun 10, 2015

@evanphx any plans to release v2.11.4 ? 😄

@evanphx
Copy link
Member

evanphx commented Jun 15, 2015

@deees Yes, I'll have a release out this week. Sorry for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@deees @evanphx