configuration: allow empty tags to mean no tag desired #791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows you to use `tag ""` in the config file to avoid inferring a tag. This is useful for example in cluster mode with phased restarts where you might want the master process to just specify the puma version and nothing else. Later in `on_worker_boot` you would manually modify the process title to suit your needs if you need more specific tags.
evanphx
added a commit
that referenced
this pull request
Oct 1, 2015
configuration: allow empty tags to mean no tag desired
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows you to use
tag ""in the config file to avoidinferring a tag.
This is useful for example in cluster mode with phased restarts
where you might want the master process to just specify the puma
version and nothing else.
Later in
on_worker_bootyou would manually modify the processtitle to suit your needs if you need more specific tags.