Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DSL need cli_options #853

Merged
merged 1 commit into from
Jan 28, 2016
Merged

DSL need cli_options #853

merged 1 commit into from
Jan 28, 2016

Conversation

xuqiyong666
Copy link
Contributor

use case:

$: puma -C puma.rb -d

but in puma.rb:

if @options[:daemon]  # *got nil, can not work*
  log_path = File.join(app_root,"log/stdout.log")
  stdout_redirect log_path , log_path
end

@xuqiyong666
DSL need cli_options
04dd026 
use case:

$: puma -C puma.rb -d

but in puma.rb:

if @options[:daemon]  # got nil, can not work
  log_path = File.join(app_root,"log/stdout.log")
  stdout_redirect log_path , log_path
end
evanphx added a commit that referenced this pull request Jan 28, 2016
@evanphx
Merge pull request #853 from Jeffrey6052/patch-1
86ef9e5 
DSL need cli_options
@evanphx evanphx merged commit 86ef9e5 into puma:master Jan 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xuqiyong666 @evanphx