Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jruby server tests #877

Merged
merged 1 commit into from Feb 4, 2016

Commits on Feb 4, 2016

  1. Fix jruby server tests

    We were accidentally connecting to a `nil` port, in my previous tests. MRI will interpret this the same as port 0. Jruby will not and throws an error
    
    ```
    Error: test_very_large_return(TestPumaServer): TypeError: can't convert nil into String
    org/jruby/ext/socket/RubyTCPServer.java:102:in `initialize'
    org/jruby/RubyIO.java:851:in `new'
    ```
    
    This tests makes sure we're using a port number instead of nil.
    schneems committed Feb 4, 2016
    Configuration menu
    Copy the full SHA
    5f722aa View commit details
    Browse the repository at this point in the history