Fixes #922 - Correctly define file encoding as UTF-8 #924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Line 103 contains the unicode character ñ which causes this to break rake for ruby 1.9.3. Specifying the encoding for the file fixes this error.
|
Great on the quick fix. I just hit this in my travis tests if an example is needed. |
|
Unfortunately, Puma supports only Ruby 2.1 and later now. See b4a2fde. |
|
Ah ok that's understandable. The gemspec should probably be updated to reflect that as well then. Thanks! |
evanphx
added a commit
that referenced
this pull request
Mar 7, 2016
Fixes #922 - Correctly define file encoding as UTF-8
tbrisker
added a commit
to tbrisker/rake
that referenced
this pull request
Mar 8, 2016
TraceOutput#trace_on has a bug that causes the matching to fail if a string is incorrectly encoded, for example encoded as 'US-ASCII' but contains unicode characters. This causes a new exception to be thrown, losing the stack trace of the previous exception. This can occur, for example, in Ruby 1.9 when one of the dependencies of a project includes a file that contains unicode but does not specify an encoding (as the default for Ruby 1.9 is US-ASCII). This was the case in a certain version of the Puma web server, which was fixed in puma/puma#924 but was very difficult to debug due to the incorrect stack trace provided by rake.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Line 103 contains the unicode character ñ which causes this to break rake for ruby 1.9.3.
Specifying the encoding for the file fixes this error.