feat: change no-compat rule for forbid imports from rxjs/operators

closes cartant#108
pumano · Aug 11, 2023 · 708a1e4 · 708a1e4
1 parent c09676b
commit 708a1e4
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/source/rules/no-compat.ts b/source/rules/no-compat.ts
@@ -25,7 +25,7 @@ const rule = ruleCreator({
   name: "no-compat",
   create: (context) => {
     return {
-      [String.raw`ImportDeclaration Literal[value=/^rxjs\u002f/]:not(Literal[value=/^rxjs\u002f(ajax|fetch|operators|testing|webSocket)/])`]:
+      [String.raw`ImportDeclaration Literal[value=/^rxjs\u002f/]:not(Literal[value=/^rxjs\u002f(ajax|fetch|testing|webSocket)/])`]:
         (node: es.Literal) => {
           context.report({
             messageId: "forbidden",

diff --git a/tests/rules/no-compat.ts b/tests/rules/no-compat.ts
@@ -13,7 +13,6 @@ ruleTester({ types: false }).run("no-compat", rule, {
     `import { Observable } from "rxjs";`,
     `import { ajax } from "rxjs/ajax";`,
     `import { fromFetch } from "rxjs/fetch";`,
-    `import { concatMap } from "rxjs/operators";`,
     `import { TestScheduler } from "rxjs/testing";`,
     `import { webSocket } from "rxjs/webSocket";`,
     `import * as prefixedPackage from "rxjs-prefixed-package";`,
@@ -49,6 +48,12 @@ ruleTester({ types: false }).run("no-compat", rule, {
                               ~~~~~~~~~~~~~~~~~~~~~ [forbidden]
       `
     ),
+    fromFixture(
+      stripIndent`
+        import { merge } from "rxjs/operators";
+                              ~~~~~~~~~~~~~~~~ [forbidden]
+      `
+    ),
     fromFixture(
       stripIndent`
         import { asap } from "rxjs/scheduler/asap";