Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web UI doesn't reuse inflight template requests #1462

Open
strugee opened this issue Oct 14, 2017 · 2 comments
Open

Web UI doesn't reuse inflight template requests #1462

strugee opened this issue Oct 14, 2017 · 2 comments

Comments

@strugee
Copy link
Member

strugee commented Oct 14, 2017

STR:

  1. Go to a user's page
  2. Open the devtools Network pane
  3. Scroll all the way to the bottom
  4. Note how there's a ton of requests for activity-client.jade.js

This is incredibly inefficient. We need to detect that these requests are already in-flight and reuse the existing request.

@ghost
Copy link

ghost commented Oct 15, 2017

I thinks is related with this: pump.js#L497 and view.js#L225, because when the user scroll down fire, scroll more and fire again, and if the request is slow the user will be scroll up and down again, makes the request again.

I think exist better option than setInterval for that, but also should be detect if exist similar request for template

@ghost
Copy link

ghost commented Oct 16, 2017

The commit 92e9f05 will fix this issue.

But the infinite scroll has other impact in performance with current behavior (better with $(window).on('scroll'..)), but is other issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant