Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tmp_path for temp file in test #24

Merged
merged 1 commit into from
Apr 6, 2023
Merged

Conversation

svank
Copy link
Contributor

@svank svank commented Apr 6, 2023

A small tweak for the tests---using a tmp dir for the tests that save and load files. Without this change, one of these tests would sometimes fail when I used pytest-xdist to run tests across multiple cores, I assume because they were trampling each other's output files.

I also noticed that test_create_array_corrector, which I've re-named test_save_load_array_corrector, was overwriting another test in that file also called test_create_array_corrector.

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.39 🎉

Comparison is base (fa87007) 93.39% compared to head (1523c5f) 93.79%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #24      +/-   ##
==========================================
+ Coverage   93.39%   93.79%   +0.39%     
==========================================
  Files           9        9              
  Lines         757      757              
==========================================
+ Hits          707      710       +3     
+ Misses         50       47       -3     
Impacted Files Coverage Δ
tests/test_corrector.py 95.39% <100.00%> (+1.97%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jmbhughes
Copy link
Member

This is a good catch. I note that related to #25 we want to get rid of the pickling, but that's a separate thing to resolve.

@jmbhughes jmbhughes merged commit 7635d4d into punch-mission:main Apr 6, 2023
@svank svank deleted the warnings branch April 7, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants