Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for arbitrary polarization angles specification and npol system #138

Merged
merged 6 commits into from
Jul 19, 2024

Conversation

jmbhughes
Copy link
Member

@jmbhughes jmbhughes commented Jul 18, 2024

PR summary

allows arbitrary angles to be passed closing #137

Todos

  • add an arbitrary path test
  • fix representation of npol to be an arbitrary number of angles
  • remove hardcoded stereo offset angles for npol
  • improve docs
  • represents transform systems as lower cased strings internally

Test plan

Make sure CI passes

Breaking changes

None

Related Issues

Closes #137

@jmbhughes jmbhughes linked an issue Jul 18, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 94.77612% with 7 lines in your changes missing coverage. Please review.

Project coverage is 92.93%. Comparing base (cbf4291) to head (9a37cbe).

Files Patch % Lines
solpolpy/instruments.py 69.23% 4 Missing ⚠️
solpolpy/core.py 93.75% 2 Missing ⚠️
solpolpy/polarizers.py 98.55% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #138      +/-   ##
==========================================
- Coverage   93.13%   92.93%   -0.21%     
==========================================
  Files           9        9              
  Lines         481      538      +57     
==========================================
+ Hits          448      500      +52     
- Misses         33       38       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmbhughes jmbhughes self-assigned this Jul 18, 2024
@jmbhughes jmbhughes changed the title Add angles Add arbitrary angle conversion support Jul 18, 2024
@jmbhughes jmbhughes changed the title Add arbitrary angle conversion support Add support for arbitrary polarization angles specification Jul 18, 2024
@jmbhughes jmbhughes marked this pull request as draft July 18, 2024 20:45
@jmbhughes jmbhughes changed the title Add support for arbitrary polarization angles specification Add support for arbitrary polarization angles specification and npol Jul 18, 2024
@jmbhughes jmbhughes changed the title Add support for arbitrary polarization angles specification and npol Add support for arbitrary polarization angles specification and npol system Jul 18, 2024
@jmbhughes jmbhughes linked an issue Jul 19, 2024 that may be closed by this pull request
@jmbhughes jmbhughes marked this pull request as ready for review July 19, 2024 22:26
@jmbhughes jmbhughes merged commit 737b0b9 into main Jul 19, 2024
7 of 8 checks passed
@jmbhughes jmbhughes deleted the add-angles branch July 19, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add mzp to npol conversion Add support for arbitrary polarization angles specification
1 participant