New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/api #132
Feature/api #132
Conversation
This is where live content will be transfered to for APIs
* Fixes spacing for scenarios * Moves feature for checkboxes out of the label as that gets hard to read
Formatting of content, sorting, and pagination
Cleans up work and makes it unit testable
Hopefully will stop Travis lockup
This is OK to review. The tests seem to be a little fragile because I'm randomly generating stuff. Thoughts on that? |
const organize = utils.organize(query); | ||
|
||
return database.select('*').from('live').orderBy(organize.sort.by, organize.sort.dir).offset(organize.page.offset).limit(organize.page.limit).then(rows => { | ||
return database('live').count('id').then(total => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Case in point
OK. Review complete. Some fixes required. Non-PR-fix action items:
|
|
@Snugug failed test:
|
This is the test that sometimes and sometimes does not fail. I may need to re-write this test |
Damnit, it worked with just logging stuff out. If I don't, will it?
Trying this again. I'm going to be _so_ mad if this works
@scottnath I frickin give up. logging out the things that need to be identical makes the tests pass, but not having them logged out makes it fail. So ya know what, I'm keeping the logging in |
REST API Endpoints.
Code review can take place as I'm finishing up tests
Resolves #114
DCO 1.1 Signed-off-by: Sam Richard <sam@snug.ug>