Feature/save revision no conflict #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows for revisions to be saved without going through the approval process
Closed
| @@ -358,10 +359,12 @@ const routes = application => { | |||
| return next(); | |||
| } | |||
|
|
|||
| // Validation | |||
| const validated = content.form.validate(req.body, type); | |||
| if (req.body.submit === 'Save Revision') { | |||
There was a problem hiding this comment.
Can Save Revision be added to config so that we don't have to control what this text is in multiple places?
There was a problem hiding this comment.
Yah, but we nreally really need to get these things out of config and replace them with #63
|
@Snugug 3 responses. Indentation ones...meh, moving the text to config...not meh |
added 2 commits
August 10, 2016 15:20
Merge conflicts makes tabs not spaces and breaks all the happy things
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we can save revisions!
Resolves #221
DCO 1.1 Signed-off-by: Sam Richard <sam@snug.ug>