Users #44
Closed
Users #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| id: 'admin', | ||
| allows: [ | ||
| { | ||
| resources: '/content/services', |
There was a problem hiding this comment.
Will we need to do this for every single content type?
There was a problem hiding this comment.
Can we abstract this for ease of our users? Instead of exposing ACL directly to them?
There was a problem hiding this comment.
@Snugug There are other ways to do this, but was getting very heavy for this PR. Ok if I make a story for that?
|
@Snugug all PR changes are in. I've very close on the tests, but it just won't recognize the cookies. |
| @@ -44,18 +45,58 @@ module.exports = { | |||
| path: 'content', | |||
| label: 'Content', | |||
| }, | |||
| { | |||
| path: 'users', | |||
There was a problem hiding this comment.
Please follow the pattern in content
| const userRoles = config.roles.config; | ||
|
|
||
| // memoryBackend starts with a lowercase from node-acl | ||
| const acl = new NodeAcl(new NodeAcl.memoryBackend()); // eslint-disable-line new-cap |
There was a problem hiding this comment.
So, found your problem with everyone being unloaded on server crash. Using memory backend. Should use knex backend
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Snugug not an official PR. Please offer feedback on this code so I can make changes on tuesday.