Add actionsFromClass method for use in extended Policy classes #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisalley
force-pushed
the
add-actions-from-class-method
branch
from
37ffbb0
to
134d9f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a new method that can be added to the constructor of the extended policy class that will add all class methods to the actions map:
this.actionsFromClass.apply(this)Using
apply(this)allows us to use the scope of the extended policy withinPolicy, otherwisethiswill refer to the basePolicyclass, meaning that we'll only see methods such ascan,add, andcopy, which is not what we want.Open to any suggestions for simplifying this further.
Addresses #43