Merge pull request #30 from LukasReschke/use-simple-array-cache

Cache results of `getTimezoneNameNoLocationSpecific`
punic · Jan 17, 2015 · 5b82f00 · 5b82f00
2 parents 746398b + 5b69f44
commit 5b82f00
Showing 1 changed file with 10 additions and 0 deletions.
diff --git a/code/Calendar.php b/code/Calendar.php
@@ -14,6 +14,9 @@
  */
 class Calendar
 {
+    /** @var array */
+    protected static $timezoneCache;
+
     /**
      * Convert a date/time representation to a {@link http://php.net/manual/class.datetime.php \DateTime} instance.
      * @param number|\DateTime|string $value An Unix timestamp, a `\DateTime` instance \DateTime or a string accepted by {@link http://php.net/manual/function.strtotime.php strtotime}.
@@ -402,6 +405,11 @@ public static function getDayperiodName($value, $width = 'wide', $locale = '', $
      */
     public static function getTimezoneNameNoLocationSpecific($value, $width = 'long', $kind = '', $locale = '')
     {
+        $cacheKey = json_encode(array($value, $width, $kind, $locale));
+        if(isset(self::$timezoneCache[$cacheKey])) {
+            return self::$timezoneCache[$cacheKey];
+        }
+
         $result = '';
         if (!empty($value)) {
             $receivedPhpName = '';
@@ -502,6 +510,8 @@ public static function getTimezoneNameNoLocationSpecific($value, $width = 'long'
             }
         }
 
+        self::$timezoneCache[$cacheKey] = $result;
+
         return $result;
     }