Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

co.paralleluniverse.capsule.Jar (capsule-util): addPackageOf(capsule.UserSettings.class) throws IllegalArgumentException #40

Closed
circlespainter opened this issue Oct 8, 2014 · 2 comments · Fixed by #41

Comments

@circlespainter
Copy link
Member

Line 459 as of now (file visitor in tree walking of addDir), it looks like relativize in Path needs both paths (source object and parameter) to be either absolute or relative (found logic in http://www.docjar.com/html/api/com/sun/nio/zipfs/ZipPath.java.html l. 229).

Will ask to merge a small fix fork soon.

@pron
Copy link
Contributor

pron commented Oct 8, 2014

Hmm. I would expect the file argument to visitFile to match the "absoluteness" of the dir argument passed to walkFileTree. But since dir is relative in this case, so if you get this exception I guess file is absolute?

@circlespainter
Copy link
Member Author

Yes that's precisely my case, about to commit and merge-request a fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants