Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HttpChannel calls unsupported close() on 400-600 HTTP codes #49

Closed
roded opened this issue Feb 4, 2016 · 7 comments
Closed

HttpChannel calls unsupported close() on 400-600 HTTP codes #49

roded opened this issue Feb 4, 2016 · 7 comments
Assignees
Labels

Comments

@roded
Copy link
Contributor

roded commented Feb 4, 2016

Hi,
Seems like HttpChannel is calling its close() on HTTP errors (400-600) and redirects.
This seems to make it impossible to return HTTP errors without an UnsupportedOperationException.
Or is there something I missed?

@circlespainter
Copy link
Member

Can you try with 0.6.0-SNAPSHOT?

@circlespainter circlespainter self-assigned this Feb 4, 2016
@roded
Copy link
Contributor Author

roded commented Feb 5, 2016

Same behaviour.
Should I submit a PR which removes the close() calls?

@circlespainter
Copy link
Member

I see it's still present in comsat-actors-servlet, is that the backend you're using?

It should be been fixed already in the Sonatype-published 0.6.0-SNAPSHOT artifacts for comsat-actors-undertow and comsat-actors-netty (which at present are from the webperf branch about performance improvements).

Thanks for proposing a PR but I'd rather do it myself as I'd like to refactor few more things according to the latest performance work done in the Netty and Undertow backends.

Also, if you're not forced to use servlets I suggest you to consider the Netty or Undertow ones as they're faster (because they integrate the backend's native API directly).

@roded
Copy link
Contributor Author

roded commented Feb 5, 2016

Yeah, I've been using comsat-actors-servlet.
I'll switch promptly.

Is there a release date for 0.6.0?

@circlespainter
Copy link
Member

No but probably it won't be long.

@circlespainter
Copy link
Member

A new 0.6.0-SNAPSHOT should be available on Sonatype with a fix.

@circlespainter
Copy link
Member

0.6.0 released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants