Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutoWebActorHandler filtered scan #56

Closed
roded opened this issue Apr 20, 2016 · 5 comments
Closed

AutoWebActorHandler filtered scan #56

roded opened this issue Apr 20, 2016 · 5 comments
Assignees

Comments

@roded
Copy link
Contributor

roded commented Apr 20, 2016

AutoWebActorHandler currently scans the entire classpath for @WebActor annotated classes.
In my case, this is a shame as there's a single @WebActor annotated class to be found.

As I rather not lose the convenience of the AutoWebActorHandler, I'm wondering if it would be possible to allow the handler to accept a specific package name for scanning in order to save some of the loading time.

@roded roded changed the title AutoWebActorHandler focused scanning AutoWebActorHandler filtered scanning Apr 20, 2016
@roded roded changed the title AutoWebActorHandler filtered scanning AutoWebActorHandler filtered scan Apr 20, 2016
@circlespainter circlespainter self-assigned this Apr 21, 2016
@circlespainter
Copy link
Member

Something can surely be done; how significant in your case is the bootstrap slowdown due to the @WebActor-related classpath scanning?

@roded
Copy link
Contributor Author

roded commented Apr 21, 2016

Locally the scan takes around 5 seconds (+/- depending on debugging and etc.).
It would be a nice delay to cut.

circlespainter pushed a commit that referenced this issue Apr 26, 2016
@circlespainter
Copy link
Member

Could you try with a 0.7.1-SNAPSHOT built from the impl-56 branch? You can now construct Undertow's and Netty's AutoWebActorHandler by passing a list of packages to limit the class loading from: let me know if and by how much this improves your bootstrap time.

@roded
Copy link
Contributor Author

roded commented Apr 26, 2016

That brought it down to less than 2 seconds which is great (I didn't bother doing any actual measurements though).
Thanks!

@circlespainter
Copy link
Member

Good! You should now be able to download a 0.7.1-SNAPSHOT containing the feature from SonaType too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants