Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

113 google cloud provider #164

Merged
merged 5 commits into from Jul 21, 2023
Merged

113 google cloud provider #164

merged 5 commits into from Jul 21, 2023

Conversation

VKotwicki
Copy link
Contributor

No description provided.

@VKotwicki VKotwicki linked an issue Jul 21, 2023 that may be closed by this pull request
Google Cloud Provider #113
Closed
@sonarcloud
Copy link

sonarcloud bot commented Jul 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
16.9% 16.9% Duplication

@VKotwicki VKotwicki merged commit a325e2d into main Jul 21, 2023
6 checks passed
@VKotwicki VKotwicki deleted the 113-google-cloud-provider branch July 21, 2023 15:48
@adamgross42
Copy link
Contributor

Hi folks, it looks like this missed adding a Google Cloud package to requirements.txt. Do you know which package that should be? Otherwise it results in ModuleNotFoundError: No module named 'google.cloud'.

@SimonGurney
Copy link
Contributor

Ah, nightmare. Not sure how this got past our testing to be honest but we don't automatically test providers.

I'll get it sorted, unless you want to raise a PR and get a contributor badge?

@adamgross42
Copy link
Contributor

Sure, I can put up a PR, I think I found the package name.

@adamgross42 adamgross42 mentioned this pull request Jul 28, 2023
Merged
@SimonGurney
Copy link
Contributor

Thanks for sorting. I'll push a tag tomorrow to update the docker image. The nightly build should occur at midnight if you wanted to test it out before then.

@adamgross42
Copy link
Contributor

I'm not using this within Docker, I have it working fine locally now, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imnotbrandon imnotbrandon imnotbrandon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Google Cloud Provider
4 participants
@VKotwicki @adamgross42 @SimonGurney @imnotbrandon