3.37.0 Incorrect doc localization reference

[stepanjakl]

Hello,

I am quite unsure what caused this issue, but suddenly in an A3 app, the current localization key stopped appearing. The localization object started pointing to the previous doc version. I don't really know why the previous doc versions of the home page were created in the first place.

I dug deeper into the codebase and found that the localizations array consists of few different docs:

apostrophe/modules/@apostrophecms/i18n/index.js

Line 130 in f130c24

const localizations = await self.apos.doc.db.find({

It just happens to pick the first object that satisfies this condition (which in our case is the previous doc version):

apostrophe/modules/@apostrophecms/i18n/index.js

Line 148 in f130c24

const doc = localizations.find(doc => doc.aposLocale.split(':')[0] === name);

I managed to fix it with a modified condition:

const doc = localizations.find(doc => doc.aposLocale.split(':')[0] === name && doc.aposLocale.split(':')[1] === context.aposLocale.split(':')[1]);

I can create a PR for this if you think it's a suitable solution.

However, my suggestion only treats the symptomps as the cause of the issue (i.e. the generated previous docs) might lay somewhere else.

[ValJed]

Hi @stepanjakl !
Thank you for this detailed issue.
You're right this is a bug from apostrophe, but in the localization the previous docs should not be available.
The issue comes from the property aposMode that is not properly updated when switching a published doc into a previous one.

I'm currently working on a fix, I keep you informed.

[ValJed]

A PR is open to fix this issue. It should be available in the next release.
You can use it or test it on this branch if needed.

[stepanjakl]

Hello @ValJed, thank you for sorting this out so quickly! It is working well now.