Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MahApps Resources #93

Merged
merged 3 commits into from
Aug 29, 2019
Merged

Conversation

timunie
Copy link
Contributor

@timunie timunie commented Aug 19, 2019

What I did so far

Renamed (Hopefully all DynamicResources) according to new MahApps.Metro names. If we don't update this, ChildWindow is broken.

What we should decide

Name resources in the same way like MahApps resource

  • SimpleChildWindowFocusVisual -> MahApps.Styles.ChildWindow.FocusVisualStyle
  • ChildWindowTemplate -> MahApps.Templates.ChildWindow
  • MahApps.Styles.ChildWindow

Closes

Closes #92

Happy coding
Tim

Renamed (Hopefully all DynamicResources) according to new MahApps.Metro names. If we don't update this, ChildWindow is broken.
@punker76 punker76 changed the title Update Resources /!\ Please review this before Merging /!\ Update MahApps Resources Aug 29, 2019
@punker76 punker76 added this to the 2.0.0 milestone Aug 29, 2019
- SimpleChildWindowFocusVisual -> MahApps.Styles.ChildWindow.FocusVisualStyle
- ChildWindowTemplate -> MahApps.Templates.ChildWindow
- MahApps.Styles.ChildWindow
@punker76 punker76 merged commit e40b573 into punker76:dev Aug 29, 2019
@timunie timunie deleted the UpdateResourceNames branch August 29, 2019 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MahApps Resources are renamed
2 participants