simplification of Conic parameter calculation #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
papr
approved these changes
May 11, 2021
papr
added a commit
to pupil-labs/pupil
that referenced
this pull request
May 11, 2021
pye3d v0.0.7 includes the following improvements - Simplification of `Conic` parameter calculation - [#26](pupil-labs/pye3d-detector#26) - Incremental performance improvements - [#27](pupil-labs/pye3d-detector#27) - Correctly apply corneal-refraction correction to `diameter_3d` result - [#28](pupil-labs/pye3d-detector#28)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
calculation of parameters A-F of the general implicit form of the conic can be simplified (see linked Wikipedia): new version are the old parameters multiplied by a²b² (which doesn't change the conic) and D,E,F can make use of previously calculated A,B,C.