-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Curriculum revamp to pages: Phase 1 #1272
Merged
mahesh-krishnakumar
merged 219 commits into
master
from
issues/1258/phase-1-detach-levels
Aug 24, 2023
Merged
Curriculum revamp to pages: Phase 1 #1272
mahesh-krishnakumar
merged 219 commits into
master
from
issues/1258/phase-1-detach-levels
Aug 24, 2023
+6,811
−9,298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
Latest commit: |
8350c88
|
Status: | ✅ Deploy successful! |
Preview URL: | https://6678a505.pupilfirst-docs.pages.dev |
Branch Preview URL: | https://issues-1258-phase-1-detach-l.pupilfirst-docs.pages.dev |
…m/pupilfirst/pupilfirst into issues/1258/phase-1-detach-levels
shilendras
reviewed
Aug 21, 2023
shilendras
reviewed
Aug 24, 2023
app/frontend/courses/students/components/CoursesStudents__StudentOverlay.res
Outdated
Show resolved
Hide resolved
bodhish
approved these changes
Aug 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
level_id
column. This was required to track level based progress. This would be removed as progress can be tracked from the completion status of milestone targets. The same applies to the students grouped as a team, where the startup table holds thelevel_id
.Cleanup all course progression services based on levels. We currently have an option to control how far a student can level up after completing a particular level. This course's progression setting will not be relevant, and everything will be tied to the targets that are marked as milestoneconverted to maximum allowed pending submissions.https://www.figma.com/file/tkL4qlaMS7Cd179lwF3ySJ/RFC-Pages-for-Curriculum-Phase-1?node-id=0%3A1&t=yEmoSyC8tpEnE0Eq-1
@pupilfirst/developers
Spec failure list after removing association of student with level
Spec fix list
The updates and new specs that are needed: