Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Curriculum revamp to pages: Phase 1 #1272

Merged
merged 219 commits into from
Aug 24, 2023

Conversation

mahesh-krishnakumar
Copy link
Contributor

@mahesh-krishnakumar mahesh-krishnakumar commented Apr 19, 2023

Proposed Changes

  • Write a data migration to move milestone attribute from target group to target.
  • Add a new column in target table to track milestone number
  • Indicate milestone on each target in curriculum UI for students.
  • Remove milestone property from target group.
  • Update progress in the student report and own report (shown to students) based on percentage completion of each milestone targets. The information shown in both pages are identical and thus can probably rely on the same service which collates data
  • Student distribution bar in students page and organizations page will change to the number of students who have completed milestones
  • Remove association of students to level - Current student (Founder table) has a level_id column. This was required to track level based progress. This would be removed as progress can be tracked from the completion status of milestone targets. The same applies to the students grouped as a team, where the startup table holds the level_id.
  • Remove manual level up logic. This is used to process level up once students invokes level up from the UI after completion of a level.
  • Remove level progress from all UIs, such as check mark in level dropdown in curriculum.
  • Use the cached data to decide which level should be loaded first when a student visits a course curriculum page for the first time (or the last viewed target).
  • Update course completion timestamping to mark itself when all milestones in a course are completed.
  • Cleanup all course progression services based on levels. We currently have an option to control how far a student can level up after completing a particular level. This course's progression setting will not be relevant, and everything will be tied to the targets that are marked as milestone converted to maximum allowed pending submissions.
  • Allow prerequisites between target to be set between levels. This can be used to ensure that higher level milestones are performed only after lower level ones as per the current flow.
  • In the students page and the review page, clean up level based filtering. This would mean also removing level indication in each student in the list and also in a submission.
  • Migrate the current level progression mechanism to the new one. The number of allowed level ups should map to the number of allowed pending submissions for different targets before allowing submission for a new target.

https://www.figma.com/file/tkL4qlaMS7Cd179lwF3ySJ/RFC-Pages-for-Curriculum-Phase-1?node-id=0%3A1&t=yEmoSyC8tpEnE0Eq-1

@pupilfirst/developers

Spec failure list after removing association of student with level

Spec fix list

  • ./spec/system/school/courses/teams/details_spec.rb
  • ./spec/system/users/sign_in_spec.rb
  • ./spec/system/courses/review_spec.rb
  • ./spec/system/organisations/show_spec.rb
  • ./spec/system/school/courses/teams/actions_spec.rb
  • ./spec/system/courses/students_spec.rb
  • ./spec/system/school/courses/cohorts/index_spec.rb
  • ./spec/system/submissions/review_spec.rb
  • /spec/system/school/coaches_index_spec.rb
  • ./spec/system/home/index_spec.rb
  • ./spec/system/school/admin_spec.rb
  • ./spec/system/submissions/show_spec.rb
  • ./spec/system/certificates/certificate_link_on_curriculum_spec.rb
  • ./spec/system/courses/curriculum_spec.rb
  • ./spec/system/primary_domain_redirection_spec.rb
  • ./spec/system/courses/calendar_spec.rb
  • ./spec/system/school/overview_spec.rb
  • ./spec/system/courses/apply_spec.rb
  • ./spec/system/footer_spec.rb
  • target_details_editor_spec.rb
  • bot_reviewer_repeat_rejection_alert_spec.rb
  • markdown_editor_spec.rb
  • teams/index_spec.rb
  • courses/show_spec.rb
  • users/edit_spec.rb
  • faculty/index_spec.rb
  • targets/show_spec.rb
  • school/courses/curriculum_editor_spec.rb
  • school/courses_index_spec.rb
  • notifications/show_spec.rb
  • app_router_spec.rb
  • users/manual_sign_out_spec.rb
  • school/communities_editor_spec.rb
  • users/referrer_spec.rb
  • school/navbar_spec.rb
  • users/update_email_spec.rb
  • school/courses/evaluation_criteria_index_spec.rb
  • school/courses/calendars_spec.rb
  • school/courses/applicants_spec.rb
  • faculty/connect_link_spec.rb
  • school/courses/certificates_spec.rb
  • student/inner_navbar_spec.rb
  • courses/leaderboard_spec.rb
  • community/community_spec.rb
  • organisations/index_spec.rb
  • school/courses/exports_spec.rb
  • users/dashboard_spec.rb
  • students/report_spec.rb
  • school/courses/cohorts/details_spec.rb

The updates and new specs that are needed:

  • Auto issue of certificate needs to be updated
  • Restructure curriculum spec to remove level related locks and course progression behaviour change and new milestone system
  • Update course index spec in admin to reflect new progression behaviour setting.
  • Write new spec for courses cohorts page for viewing student data.
  • Update report spec to check the milestone completion status
  • Update report in students page to show milestone completion status.

@pupilfirst pupilfirst deleted a comment from netlify bot Apr 28, 2023
@pupilfirst pupilfirst deleted a comment from netlify bot Apr 28, 2023
@pupilfirst pupilfirst deleted a comment from netlify bot Apr 28, 2023
@pupilfirst pupilfirst deleted a comment from cloudflare-pages bot Apr 28, 2023
@cloudflare-pages
Copy link

cloudflare-pages bot commented May 9, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8350c88
Status: ✅  Deploy successful!
Preview URL: https://6678a505.pupilfirst-docs.pages.dev
Branch Preview URL: https://issues-1258-phase-1-detach-l.pupilfirst-docs.pages.dev

View logs

Copy link
Member

@bodhish bodhish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bodhish bodhish dismissed harigopal’s stale review August 24, 2023 15:58

Suggesgted Changes are Fixed

@mahesh-krishnakumar mahesh-krishnakumar merged commit 710e567 into master Aug 24, 2023
4 checks passed
@harigopal harigopal deleted the issues/1258/phase-1-detach-levels branch November 17, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
9 participants