Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Founders to Students #1309

Merged
merged 42 commits into from
Jul 20, 2023
Merged

Rename Founders to Students #1309

merged 42 commits into from
Jul 20, 2023

Conversation

youmari
Copy link
Contributor

@youmari youmari commented May 28, 2023 •
edited by bodhish

youmari and others added 24 commits May 28, 2023 13:57
@youmari
fix: Rename founders controller to students controller
21eaa52
@youmari
fix: Rename Founders to students
be9ec18
@youmari
fix: Rename Founder to Student
4c5de81
@yash-learner @irajsuhail @youmari
Fix Styles effected by RTL-UI changes (pupilfirst#1279)
d693633 
Co-authored-by: Raj Suhail <rajsuhailmalik@gmail.com>
@kaisersakhi @youmari
Add functionality to log user name changes (pupilfirst#1273)
22ac6fd
@yash-learner @harigopal
@vinutv @youmari
Organisation admins and school admins can see the inactive cohorts (p…
ac7b23d 
…upilfirst#1278)

Co-authored-by: Hari Gopal <mail@harigopal.in>
Co-authored-by: vinu tv <vinutv91@gmail.com>
@mabras @youmari
@hammaazarok @harigopal
Increase i18n coverage (pupilfirst#1204)
a0453e5 
Co-authored-by: Yassine Omari <yassine@oddcamp.com>
Co-authored-by: Hamma Alamin <hamm.alamin@feng.sebhau.edu.ly>
Co-authored-by: Hari Gopal <mail@harigopal.in>
@mabras @youmari
Remove unused assets (pupilfirst#1184)
dbebb07
@harigopal @youmari
Separate primary and secondary nav names (pupilfirst#1288)
13acacc
@mabras @harigopal @youmari
Make the certificate ID a link (pupilfirst#1275)
dc86798 
Co-authored-by: Hari Gopal <mail@harigopal.in>
@kaisersakhi @youmari
List students based on the last seen status in students page (pupilfi…
1a63ee7 
…rst#1289)
@mabras @youmari
Always center the school name (pupilfirst#1276)
a2cbd2d
@youmari @irajsuhail
Fix text overflow in footer links (pupilfirst#1286)
5ba1b45 
Co-authored-by: Raj Suhail <rajsuhailmalik@gmail.com>
@yash-learner @youmari
Require confirmation when closing review tab that has some feedback (p…
5bd887b 
…upilfirst#1281)
@kaisersakhi @youmari
Remove faculty_id from target table (pupilfirst#1290)
f9280af
@harigopal @youmari
Document some essential env vars with defaults [skip ci]
3e0ac6c
@youmari @mahesh-krishnakumar
fix: School names do not show in email form (pupilfirst#1304)
d855020 
Co-authored-by: Mahesh Krishna Kumar <maheshcet@gmail.com>
@harigopal @youmari
Specify exact version of Node.js [skip ci]
f9c2ee4 
The asdf-nodejs plugin dropped support for partial and codename
versions: https://github.com/asdf-vm/asdf-nodejs#partial-and-codename-versions
@harigopal @youmari
Show a custom page when Discord account linking is required (pupilfir…
6be02c8 
…st#1292)
@youmari
Merge remote-tracking branch 'upstream/master' into fix/Rename-founde…
2fa6e21 
…rs-to-students
@youmari
fix: Rubocop
8857ddc
@youmari
fix
8b5c69e
@youmari
fix: more rename
6cd5132
@youmari
fix: test
95ccb53
@youmari youmari marked this pull request as ready for review May 29, 2023 10:08
@youmari youmari mentioned this pull request May 29, 2023
Closed
@harigopal
Copy link
Member

harigopal commented May 29, 2023 •
edited

@bodhish Note, this may contain breaking changes that necessitate a version bump.

@youmari youmari changed the title fix: Rename founders controller to students controller fix: Rename Founders to Students May 29, 2023
@harigopal harigopal requested a review from bodhish May 29, 2023 12:40
@youmari youmari force-pushed the fix/Rename-founders-to-students branch from 769655e to 95ccb53 Compare June 7, 2023 15:56
bodhish
bodhish requested changes Jul 18, 2023
View reviewed changes
Copy link
Member

@bodhish bodhish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The migration should be tested against production data.
  • founder_tags in School model must be migrated. (Look into act as taggable documentation)

db/migrate/20230528092206_rename_table_founders_to_students.rb Outdated Show resolved Hide resolved
app/controllers/application_controller.rb Outdated Show resolved Hide resolved
app/models/school.rb Show resolved Hide resolved
app/models/target.rb Outdated Show resolved Hide resolved
app/models/target.rb Outdated Show resolved Hide resolved
app/models/timeline_event.rb Outdated Show resolved Hide resolved
docs/developers/upgrading.md Outdated Show resolved Hide resolved
spec/system/school/courses/target_details_editor_spec.rb Outdated Show resolved Hide resolved
@bodhish bodhish changed the title fix: Rename Founders to Students Rename Founders to Students Jul 18, 2023
@bodhish bodhish requested a review from harigopal July 18, 2023 10:14
@bodhish bodhish merged commit 6f2ea8c into pupilfirst:master Jul 20, 2023
3 checks passed
@yash-learner yash-learner mentioned this pull request Aug 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bodhish bodhish bodhish requested changes

@harigopal harigopal harigopal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@youmari @harigopal @bodhish @yash-learner @kaisersakhi @mabras