Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add maintenance mode #1361

Merged
merged 8 commits into from
Jul 19, 2023
Merged

Add maintenance mode #1361

merged 8 commits into from
Jul 19, 2023

Conversation

bodhish
Copy link
Member

@bodhish bodhish commented Jul 18, 2023

Proposed Changes

image

@pupilfirst/developers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Check if route, query, or mutation authorization looks correct.
    • Add tests for authorization, if required.
  • Ensure that UI text is kept in I18n files.
  • Update developer and product docs, where applicable.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Check if new tables or columns that have been added need to be handled in the following services:
    • Users::DeleteAccountService
    • Courses::CloneService
    • Courses::DeleteService
    • Courses::DemoContentService
    • Levels::CloneService
    • Schools::DeleteService
  • Check if changes in packaged components have been published to npm.
  • Add development seeds for new tables.
  • If the updates involve Graph mutations ensure that the files are migrated to the new approach without a mutator.

@cloudflare-pages
Copy link

cloudflare-pages bot commented Jul 18, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: ce707f3
Status: ✅  Deploy successful!
Preview URL: https://bc1cc22c.pupilfirst-docs.pages.dev
Branch Preview URL: https://issues-1360-maintenance-mode.pupilfirst-docs.pages.dev

View logs

@bodhish bodhish marked this pull request as ready for review July 19, 2023 07:26
@yash-learner yash-learner self-requested a review July 19, 2023 07:52
Copy link
Member

@yash-learner yash-learner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bodhish bodhish merged commit dd74090 into master Jul 19, 2023
4 checks passed
@irajsuhail irajsuhail linked an issue Jul 20, 2023 that may be closed by this pull request
@harigopal harigopal deleted the issues/1360/maintenance-mode branch November 17, 2023 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Maintenance Mode for the application
3 participants