Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for auto-deploy #1366

Merged
merged 3 commits into from
Jul 20, 2023
Merged

Add check for auto-deploy #1366

merged 3 commits into from
Jul 20, 2023

Conversation

bodhish
Copy link
Member

@bodhish bodhish commented Jul 20, 2023

Adds a repository variable check for disabling auto deploy

@pupilfirst/developers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Check if route, query, or mutation authorization looks correct.
    • Add tests for authorization, if required.
  • Ensure that UI text is kept in I18n files.
  • Update developer and product docs, where applicable.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Check if new tables or columns that have been added need to be handled in the following services:
    • Users::DeleteAccountService
    • Courses::CloneService
    • Courses::DeleteService
    • Courses::DemoContentService
    • Levels::CloneService
    • Schools::DeleteService
  • Check if changes in packaged components have been published to npm.
  • Add development seeds for new tables.
  • If the updates involve Graph mutations ensure that the files are migrated to the new approach without a mutator.

@cloudflare-pages
Copy link

cloudflare-pages bot commented Jul 20, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: d0f7912
Status: ✅  Deploy successful!
Preview URL: https://026c70b9.pupilfirst-docs.pages.dev
Branch Preview URL: https://issues-1365-disable-auto-dep.pupilfirst-docs.pages.dev

View logs

@bodhish bodhish marked this pull request as ready for review July 20, 2023 09:45
@bodhish bodhish linked an issue Jul 20, 2023 that may be closed by this pull request
@bodhish bodhish merged commit 7e9936a into master Jul 20, 2023
4 checks passed
@harigopal harigopal deleted the issues/1365/disable-auto-deploy branch November 17, 2023 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an option to disable auto deploy
2 participants