-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for embedding the scribehow links #1411
Merged
mahesh-krishnakumar
merged 9 commits into
pupilfirst:master
from
yash-learner:issues/1381/support-scribehow-embedding
Aug 28, 2023
Merged
Add support for embedding the scribehow links #1411
mahesh-krishnakumar
merged 9 commits into
pupilfirst:master
from
yash-learner:issues/1381/support-scribehow-embedding
Aug 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harigopal
requested changes
Aug 21, 2023
harigopal
previously approved these changes
Aug 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything works well!
yash-learner
changed the base branch from
issues/1258/phase-1-detach-levels
to
master
August 24, 2023 20:07
yash-learner
changed the base branch from
master
to
issues/1258/phase-1-detach-levels
August 24, 2023 20:17
…" across the whole file
Co-authored-by: Hari Gopal <mail@harigopal.in>
yash-learner
force-pushed
the
issues/1381/support-scribehow-embedding
branch
from
August 24, 2023 21:20
66afb37
to
7218982
Compare
yash-learner
changed the base branch from
issues/1258/phase-1-detach-levels
to
master
August 24, 2023 21:21
harigopal
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1381
Proposed Changes
oembed.rb
and theresolver.rb
add_support_for_scribehow_links_embedding.mp4
@pupilfirst/developers
Merge Checklist
Users::DeleteAccountService
Courses::CloneService
Courses::DeleteService
Courses::DemoContentService
Levels::CloneService
Schools::DeleteService
npm
.