Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for embedding the scribehow links #1411

Conversation

yash-learner
Copy link
Member

@yash-learner yash-learner commented Aug 20, 2023

Closes #1381

Proposed Changes

  • Add scribehow_fallback_provider
  • Update the oembed.rb and the resolver.rb
  • Update the frontend
  • Update CSP
  • Check for spec updates
  • Update the documentation
add_support_for_scribehow_links_embedding.mp4

@pupilfirst/developers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Check if route, query, or mutation authorization looks correct.
    • Add tests for authorization, if required.
  • Ensure that UI text is kept in I18n files.
  • Update developer and product docs, where applicable.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Check if new tables or columns that have been added need to be handled in the following services:
    • Users::DeleteAccountService
    • Courses::CloneService
    • Courses::DeleteService
    • Courses::DemoContentService
    • Levels::CloneService
    • Schools::DeleteService
  • Check if changes in packaged components have been published to npm.
  • Add development seeds for new tables.
  • If the updates involve Graph mutations ensure that the files are migrated to the new approach without a mutator.

@yash-learner yash-learner marked this pull request as ready for review August 20, 2023 20:16
@harigopal harigopal linked an issue Aug 21, 2023 that may be closed by this pull request
@harigopal harigopal self-requested a review August 21, 2023 14:53
harigopal
harigopal previously approved these changes Aug 24, 2023
Copy link
Member

@harigopal harigopal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works well!

lib/oembed/scribehow_fallback_provider.rb Outdated Show resolved Hide resolved
@yash-learner yash-learner changed the base branch from issues/1258/phase-1-detach-levels to master August 24, 2023 20:07
@yash-learner yash-learner dismissed harigopal’s stale review August 24, 2023 20:07

The base branch was changed.

@yash-learner yash-learner changed the base branch from master to issues/1258/phase-1-detach-levels August 24, 2023 20:17
@yash-learner yash-learner deleted the issues/1381/support-scribehow-embedding branch August 24, 2023 21:01
@yash-learner yash-learner restored the issues/1381/support-scribehow-embedding branch August 24, 2023 21:10
@yash-learner yash-learner reopened this Aug 24, 2023
@yash-learner yash-learner force-pushed the issues/1381/support-scribehow-embedding branch from 66afb37 to 7218982 Compare August 24, 2023 21:20
@yash-learner yash-learner changed the base branch from issues/1258/phase-1-detach-levels to master August 24, 2023 21:21
@mahesh-krishnakumar mahesh-krishnakumar merged commit 673d879 into pupilfirst:master Aug 28, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow embedding of Scribehow links
3 participants